Make skip-empty
the default behavior and remove option
#40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of the protoc-gen-twirp_ruby go module is to generate empty scaffolding files for
.proto
files that do not contain any services. We chose to make our plugin behave similarly, for easier migration / backwards compatibility.We then introduced the
skip-empty
flag opt-in to avoid generating those empty files, in #21.At this point, we're ready to remove the flag and make this the default behavior. It's common for other twirp generators to do the same, see protoc-gen-twirp_typescript, protoc-gen-twirp-java, and protoc-gen-twirp_cpp.
Since the flag is removed as part of this change, passing it on the command line with cause the plugin to error. The path forward is to simply remove
--twirp_ruby_opt=skip-empty
from the command line if present.